Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HTML Color Codes from Dixon and Moe. #321

Open
wants to merge 1 commit into
base: primary
Choose a base branch
from
Open

add HTML Color Codes from Dixon and Moe. #321

wants to merge 1 commit into from

Conversation

luiscobot
Copy link

Thank you for opening a pull request to tiny-helpers.dev ❤️

Before you submit your PR, please take a look at the contributing guidelines. :)

To make it easier for us to review and merge your PR, please make sure …

  • you only add one (!) new helper per pull request.
  • you have checked if an open PR already exists.
  • the submitted website is focused on a single, development related issue.
  • the desc field includes an "actionable sentence" (e.g. "Create something great" or "Transform something into something else").

Thank you! 🙇‍♂️

@vercel
Copy link

vercel bot commented Oct 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stefanjudis/tiny-helpers/cz1lyui7s
✅ Preview: https://tiny-helpers-git-primary.stefanjudis.vercel.app

@stefanjudis
Copy link
Owner

Hey @luiscobits, thanks so much for contributing and welcome to tiny-helpers. :)

It looks like we had a name collision and your PR is overwriting another helper. It'd be great if you could rename the generated JSON file for your helper to e.g. html-color-codes-com.json. :)

Thanks a bunch!

Copy link
Owner

@stefanjudis stefanjudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tiny suggestion to make it more compact. :)

@@ -1,10 +1,14 @@
{
"name": "HTML Color Codes",
"desc": "Genereate and export color shades and tints",
"url": "https://www.hexcolortool.com/",
"desc": "Get HTML color codes, Hex color codes, RGB and HSL values with our color picker, color chart and HTML color names.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"desc": "Get HTML color codes, Hex color codes, RGB and HSL values with our color picker, color chart and HTML color names.",
"desc": "Get HTML color codes, Hex color codes, RGB and HSL values.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants